Resolved Error Updating from XF1 to XF2

[Madhouse]

 

[Clement]

There is a bug in xF:
https://xenforo.com/community/threads/changecolumn-incorrectly-handling-set-column-type.152272/

 

[Clement]

What I did is editing the file src/XF/Db/Schema/Column.php.

On line 586, I replaced:

if ($type == 'enum' && isset($matches[2]))

By:

if (($type == 'enum' || $type == 'set') && isset($matches[2]))

Though I asked xF to confirm my understanding.

It has worked apparently so you could be doing that, though I came into another bug into my code so you should be waiting for me to release a new version in a few minutes, apply the above and try upgrading.

Clément

 

[Madhouse]

Are you asking me to edit a official XenForo file? I dont think I should be doing that as it may effect other addons we have that work just fine.

 

[Clement]

Are you asking me to edit a official XenForo file? I dont think I should be doing that as it may effect other addons we have that work just fine.

There is a bug in XenForo official files, so yes.

The other add-ons you have don't use that type of columns most certainly so the bug was never discovered.

I did that the change above and it went through correctly.
If you don't trust me then you'll have to wait for a later xF2 version to be released fixing that bug.

You can follow-up what they will say in the pointed thread I created.