Bug Fixed Fatal Errors while Installation

[Terror]

good evening,

the addon caused 3 errors on installation in 2 files...

src/addons/XFA/XFMGMediaOfTheMonth/Cron/XFMGMediaOfTheMonth.php, src/addons/XFA/XFMGMediaOfTheMonth/Listener.php.

• ErrorException: Fatal Error: Cannot use isset() on the result of a function call (you can use "null !== func()" instead)
  
• src/addons/XFA/XFMGMediaOfTheMonth/Cron/XFMGMediaOfTheMonth.php:191

#0 [internal function]: XF::handleFatalError()
#1 {main}

array(4) {
  ["url"] => string(24) "/admin.php?tools/run-job"
  ["referrer"] => string(47) "http://www.d4rkz0ne.com/admin.php?tools/run-job"
  ["_GET"] => array(1) {
   ["tools/run-job"] => string(0) ""
  }
  ["_POST"] => array(3) {
   ["_xfRedirect"] => string(132) "http://www.d4rkz0ne.com/admin.php?add-ons/XFA-XFMGMediaOfTheMonth/finalize&t=1535489348%2C37bd8bf57fd294c948cbd68dcc130285&a=install"
   ["_xfToken"] => string(8) "********"
   ["only_ids"] => string(4) "3850"
  }
}

edited the files by myself and installation seemed to work. php 5.6

best regards

 

[Clement]

Thanks for notifying, will issue a fixed version.

 

[Terror]

at least two other files are affected too...
src/addons/XFA/XFMGMediaOfTheMonth/Cron/XFMGMediaOfTheMonth.php:36
src/addons/XFA/XFMGMediaOfTheMonth/Service/Album/Create.php:36

albums are not created, contest doesn't start and who knows what else errors show up if. so please take a look at the other files too, at the moment the addon isn't usable.

i am going to deactivate the addon and create an album manually. when the addon works i have to move the files in the addon album and hope the voting phase works smoother (mode 1).

in the meantime i am going to test the addon on another board with php7 too.

 

[Clement]

I will go through all the files.

I am not running php, I guess it's why I didn't see it.