Suggestion RM marketplace code

[F2uG2u]

RMMarketplace\XFRM\Entity\ResourceItem.php

code :
suggestion from

   public function isForSaleInMarketplace()
    {
        if (($this->xfa_rmmp_type == 'none') 
                || ($this->Category->xfa_rmmp_conf == 0))
        {
            return false;
        }
        
        if ($this->xfa_rmmp_amount > 0.00)
        {
            return true;
        }
        
        return false;
    }

to

  public function isForSaleInMarketplace()
    {
      
        
        if ($this->xfa_rmmp_amount > 0.00)
        {
            return true;
        }
        
        return false;
    }

For better maybe keep to save return true only

 

[Clement]

That change does not make sense, the amount could be non 0 if the category sales configuration changed so you would want false to be returned