Bug Fixed Uninstall code partially working

[doublespaces]

Okay, so here is the error:

ErrorException: Undefined index: usd - library/XFA/ForumSales/Extends/ControllerPublic/Forum.php:37
Generated By: doublespaces, 6 minutes ago
Stack Trace
#0 /home/spoolstr/domains/spoolstreet.com/public_html/forums/library/XFA/ForumSales/Extends/ControllerPublic/Forum.php(37): XenForo_Application::handlePhpError(8, 'Undefined index...', '/home/spoolstr/...', 37, Array)
#1 /home/spoolstr/domains/spoolstreet.com/public_html/forums/library/XenForo/FrontController.php(351): XFA_ForumSales_Extends_ControllerPublic_Forum->actionAddThread()
#2 /home/spoolstr/domains/spoolstreet.com/public_html/forums/library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#3 /home/spoolstr/domains/spoolstreet.com/public_html/forums/index.php(13): XenForo_FrontController->run()
#4 {main}
Request State
array(3) {
  ["url"] => string(62) "https://bmw.spoolstreet.com/forums/buy-sell-trade.7/add-thread"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(21) {
    ["prefix_id"] => string(1) "0"
    ["title"] => string(4) "Test"
    ["message_html"] => string(11) "<p>test</p>"
    ["_xfRelativeResolver"] => string(65) "https://bmw.spoolstreet.com/forums/buy-sell-trade.7/create-thread"
    ["xfa_sell"] => string(1) "1"
    ["xfa_fss_quantity"] => string(0) ""
    ["xfa_fss_price"] => string(0) ""
    ["xfa_fss_currency"] => string(3) "usd"
    ["xfa_fss_paypal_email"] => string(22) "doublespaces@gmail.com"
    ["tags"] => string(0) ""
    ["attachment_hash"] => string(32) "b1b1278157aa2778ed3e0a1e93efd586"
    ["watch_thread"] => string(1) "1"
    ["watch_thread_email"] => string(1) "1"
    ["watch_thread_state"] => string(1) "1"
    ["discussion_open"] => string(1) "1"
    ["_set"] => array(2) {
      ["discussion_open"] => string(1) "1"
      ["sticky"] => string(1) "1"
    }
    ["poll"] => array(5) {
      ["question"] => string(0) ""
      ["responses"] => array(2) {
        [0] => string(0) ""
        [1] => string(0) ""
      }
      ["max_votes_type"] => string(6) "single"
      ["change_vote"] => string(1) "1"
      ["view_results_unvoted"] => string(1) "1"
    }
    ["_xfToken"] => string(8) "********"
    ["_xfRequestUri"] => string(38) "/forums/buy-sell-trade.7/create-thread"
    ["_xfNoRedirect"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}

I had to disable the addon because it appears broken for me. Initially, I noticed that I could create a thread without entering a price or quantity. I could also submit a post which shows the minimum quantity next to the currency, but left at 0.

 

[doublespaces]

Okay, so forget the error. My server was actually running low on space, and I think the installation of the addon did not go through properly or there was some other error.

After re-uploading and reinstalling, the error no longer occurs. However, I am still able to create a for sale post without entering a price at all. It doesn't display a buy now button, but shouldn't it demand that information if the post is being marked as 'for sale'?

 

[doublespaces]

Also, I have mange sale by anyone enabled for administrators, but I cannot manage it. I can't manage even my own for sale posts:

And when trying to install it on my test server for further testing:

And I cleared those errors and tried again. Installed it, but then the buy now option wasn't appearing. I uninstalled the addon, re-uploaded and reinstalled the addon. The old listing says just USD, doesn't show any price and I can't seem to edit the thread. So it doesn't appear that uninstalling and reinstalling the addon on my live server would help since I'd lose all the pricing information.

Also, when I go to try and make a new for sale thread on my test server now:

This is the server error:

Zend_Db_Statement_Mysqli_Exception: Mysqli prepare error: Unknown column 'xfa_fss_status' in 'field list' - library/Zend/Db/Statement/Mysqli.php:77
Generated By: doublespaces, 3 minutes ago
Stack Trace
#0 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/Zend/Db/Statement.php(115): Zend_Db_Statement_Mysqli->_prepare('INSERT INTO `xf...')
#1 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/Zend/Db/Adapter/Mysqli.php(381): Zend_Db_Statement->__construct(Object(Zend_Db_Adapter_Mysqli), 'INSERT INTO `xf...')
#2 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/Zend/Db/Adapter/Abstract.php(478): Zend_Db_Adapter_Mysqli->prepare('INSERT INTO `xf...')
#3 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/Zend/Db/Adapter/Abstract.php(574): Zend_Db_Adapter_Abstract->query('INSERT INTO `xf...', Array)
#4 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XenForo/DataWriter.php(1638): Zend_Db_Adapter_Abstract->insert('xf_thread', Array)
#5 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XenForo/DataWriter.php(1627): XenForo_DataWriter->_insert()
#6 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XenForo/DataWriter.php(1419): XenForo_DataWriter->_save()
#7 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XenForo/ControllerPublic/Forum.php(830): XenForo_DataWriter->save()
#8 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/Nobita/Teams/XenForo/ControllerPublic/Forum.php(118): XenForo_ControllerPublic_Forum->actionAddThread()
#9 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XFA/ForumSales/Extends/ControllerPublic/Forum.php(15): Nobita_Teams_XenForo_ControllerPublic_Forum->actionAddThread()
#10 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XenForo/FrontController.php(351): XFA_ForumSales_Extends_ControllerPublic_Forum->actionAddThread()
#11 /home/spoolstr/domains/spoolstreet.com/public_html/test/library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#12 /home/spoolstr/domains/spoolstreet.com/public_html/test/index.php(13): XenForo_FrontController->run()
#13 {main}
Request State
array(3) {
  ["url"] => string(64) "https://test.spoolstreet.com/forums/buy-sell-trade.40/add-thread"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(20) {
    ["title"] => string(4) "test"
    ["message_html"] => string(11) "<p>test</p>"
    ["_xfRelativeResolver"] => string(67) "https://test.spoolstreet.com/forums/buy-sell-trade.40/create-thread"
    ["xfa_sell"] => string(1) "1"
    ["xfa_fss_quantity"] => string(1) "1"
    ["xfa_fss_price"] => string(1) "1"
    ["xfa_fss_currency"] => string(3) "usd"
    ["xfa_fss_paypal_email"] => string(22) "doublespaces@gmail.com"
    ["tags"] => string(0) ""
    ["attachment_hash"] => string(32) "3f53ca5b5b525adb91e45b830abe592c"
    ["watch_thread"] => string(1) "1"
    ["watch_thread_email"] => string(1) "1"
    ["watch_thread_state"] => string(1) "1"
    ["discussion_open"] => string(1) "1"
    ["_set"] => array(2) {
      ["discussion_open"] => string(1) "1"
      ["sticky"] => string(1) "1"
    }
    ["poll"] => array(5) {
      ["question"] => string(0) ""
      ["responses"] => array(2) {
        [0] => string(0) ""
        [1] => string(0) ""
      }
      ["max_votes_type"] => string(6) "single"
      ["change_vote"] => string(1) "1"
      ["view_results_unvoted"] => string(1) "1"
    }
    ["_xfToken"] => string(8) "********"
    ["_xfRequestUri"] => string(39) "/forums/buy-sell-trade.40/create-thread"
    ["_xfNoRedirect"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}

 

[Clement]

It must mean that for some reason the issue you had and the uninstalling didn't went fine and partially reinstalled.
That's not a good thing.

Have you performed a dB back-up prior your spaces issue ?

 

[doublespaces]

I do daily backups but I accidentally deleted my most recent one freeing up space. They weren't sorted chronologically for some reason and my recent one wound up in the middle somewhere and I removed it. These errors are on the test server only. The live server didn't have the installation error, it just doesn't seem to work.

I can submit a thread without a price, without a quantity, etc. Can't access those edit thread permissions, so forth.

One really weird thing, is there are errors connected to my opengraph plugin by endless horizon. It think there is a conflict with that and what you're doing here because it access some of those same permissions:

https://xenforo.com/community/resources/endless-horizon-advanced-open-graph.5182/update?update=21351

 

[doublespaces]

Ok, I had a friend drop some columns on xf_thread and rerun the alter table code to add them again. Seemed to clear up some of the issues on the test site. Still doing some diagnosis and troubleshooting.

 

[doublespaces]

Okay, so it appears that the current forum sales version doesn't install or uninstall correctly on my site. The older version 1.1 works fine however. When I uninstalled it, a couple rows in xf_thread would not get removed. I also got some errors about the Undefined index: usd

Now that I'm back on the old version, everything is normal on the live site. I'm still diagnosing what went wrong on the test site, I suspect I'll just need to drop some tables which got left there as well.

 

[Clement]

Yeah I would assume so.

Will have to check the uninstall code to see if I didn't forget to add the changes I did to the install code during the last version development.

 

[doublespaces]

Yeah I would assume so.

Will have to check the uninstall code to see if I didn't forget to add the changes I did to the install code during the last version development.

Okay, let me know when you've had a chance to review that so I may try again... I duplicated my live site into a fresh test site and I'll try again on my test site once any potential things are fixed with the install/uninstall.